Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add marshaler methods for Destination struct #93

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

vlorinc
Copy link
Contributor

@vlorinc vlorinc commented Jan 9, 2024

Fixes #92

Issue caused by changing key of map from string to struct of type Destination which didn't implement encoding.TextMarshaler so json was not able to marshal this struct.
MarshalText and UnmarshalText methods for Destination were added to fix this problem.

@vlorinc vlorinc requested a review from a team January 9, 2024 09:36
@vlorinc vlorinc self-assigned this Jan 9, 2024
@vlorinc vlorinc linked an issue Jan 9, 2024 that may be closed by this pull request
@github-actions github-actions bot added bug Something isn't working size/S labels Jan 9, 2024
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@guvenc guvenc merged commit 456bb09 into master Jan 9, 2024
6 checks passed
@guvenc guvenc deleted the fix/routes_json_handler branch January 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error getting routes in json format
2 participants